diff --git a/CMakeLists.txt b/CMakeLists.txt index 3cab5b2..219d091 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -20,7 +20,7 @@ if(MSVC) else() #set(GCC_COVERAGE_COMPILE_FLAGS "-fprofile-arcs -ftest-coverage") #set(GCC_COVERAGE_LINK_FLAGS "-lgcov") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror -Wall") + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror -Wall -Wextra") #set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${GCC_COVERAGE_COMPILE_FLAGS}") #set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${GCC_COVERAGE_LINK_FLAGS}") endif() diff --git a/apps/notes_tk/canvas/CanvasCommandSelectorView.cpp b/apps/notes_tk/canvas/CanvasCommandSelectorView.cpp index cf50087..bec91d4 100644 --- a/apps/notes_tk/canvas/CanvasCommandSelectorView.cpp +++ b/apps/notes_tk/canvas/CanvasCommandSelectorView.cpp @@ -11,14 +11,14 @@ CanvasCommandSelectorView::CanvasCommandSelectorView() { auto circle_button = Button::Create(); - auto on_circle_click = [this](Widget* self){ + auto on_circle_click = [this](Widget*){ onCommandSelected(CanvasDrawCommand::CIRCLE); }; circle_button->setLabel("Circle"); circle_button->setMargin(2); circle_button->setOnClickFunction(on_circle_click); - auto on_line_click = [this](Widget* self){ + auto on_line_click = [this](Widget*){ onCommandSelected(CanvasDrawCommand::LINE); }; auto line_button = Button::Create(); diff --git a/apps/notes_tk/canvas/CanvasDrawingArea.cpp b/apps/notes_tk/canvas/CanvasDrawingArea.cpp index c18d653..a9bbc4a 100644 --- a/apps/notes_tk/canvas/CanvasDrawingArea.cpp +++ b/apps/notes_tk/canvas/CanvasDrawingArea.cpp @@ -31,7 +31,7 @@ bool CanvasDrawingArea::isDirty() const return Widget::isDirty() || mContentDirty; } -void CanvasDrawingArea::doPaint(const PaintEvent* event) +void CanvasDrawingArea::doPaint(const PaintEvent*) { mContentDirty = false; } diff --git a/apps/notes_tk/text_editor/TextEditorView.cpp b/apps/notes_tk/text_editor/TextEditorView.cpp index 83ee3e1..ab072d3 100644 --- a/apps/notes_tk/text_editor/TextEditorView.cpp +++ b/apps/notes_tk/text_editor/TextEditorView.cpp @@ -35,7 +35,7 @@ void TextEditorView::initialize() saveButton->setLabel("Save"); saveButton->setBackground(Theme::Sys::Color::Primary); saveButton->setMargin(2); - auto onSave = [this](Widget* self){ + auto onSave = [this](Widget*){ if(mController && mTextBox) { mController->SetContent(mTextBox->getContent()); @@ -47,7 +47,7 @@ void TextEditorView::initialize() auto clearButton = Button::Create(); clearButton->setLabel("Clear"); clearButton->setMargin(2); - auto onClear = [this](Widget* self){ + auto onClear = [this](Widget*){ if(mController && mTextBox) { mController->OnClear(); @@ -59,7 +59,7 @@ void TextEditorView::initialize() auto loadButton = Button::Create(); loadButton->setLabel("Load"); loadButton->setMargin(2); - auto onLoad = [this](Widget* self){ + auto onLoad = [this](Widget*){ if(mController && mTextBox) { mController->OnLoad(); diff --git a/plugins/circuits/src/TruthTable.cpp b/plugins/circuits/src/TruthTable.cpp index 6b20b5f..2dc6c12 100644 --- a/plugins/circuits/src/TruthTable.cpp +++ b/plugins/circuits/src/TruthTable.cpp @@ -4,8 +4,8 @@ const TruthTable::TableData TruthTable::AND_TRUTH_TABLE = { {{0, 0}, {0}} }; TruthTable TruthTable::getAndTruthTable() { - TruthTable table(2, 1); - table.setTable(AND_TRUTH_TABLE); - return table; + TruthTable table(2, 1); + table.setTable(AND_TRUTH_TABLE); + return table; } diff --git a/plugins/circuits/src/TruthTable.h b/plugins/circuits/src/TruthTable.h index f2fc8f2..e4d411c 100644 --- a/plugins/circuits/src/TruthTable.h +++ b/plugins/circuits/src/TruthTable.h @@ -8,7 +8,7 @@ class TruthTable public: using TableData = std::map, std::vector >; - TruthTable(std::size_t numInputColumns, std::size_t numOutputColumns) + TruthTable(std::size_t, std::size_t) //: mNumInputColumns(numInputColumns), // mNumOutputColumns(numOutputColumns) { diff --git a/plugins/circuits/src/visuals/ElectronicCircuitNode.cpp b/plugins/circuits/src/visuals/ElectronicCircuitNode.cpp index 1db4c1e..c3f78c9 100644 --- a/plugins/circuits/src/visuals/ElectronicCircuitNode.cpp +++ b/plugins/circuits/src/visuals/ElectronicCircuitNode.cpp @@ -21,7 +21,7 @@ void ElectronicCircuitNode::setContent(ElectronicCircuit* content) mContentDirty = true; } -void ElectronicCircuitNode::createOrUpdateGeometry(SceneInfo* sceneInfo) +void ElectronicCircuitNode::createOrUpdateGeometry(SceneInfo*) { mInputTerminalNodes.clear(); mWireNodes.clear(); diff --git a/plugins/circuits/src/visuals/LogicGateNode.cpp b/plugins/circuits/src/visuals/LogicGateNode.cpp index 9915cad..245d93d 100644 --- a/plugins/circuits/src/visuals/LogicGateNode.cpp +++ b/plugins/circuits/src/visuals/LogicGateNode.cpp @@ -33,7 +33,7 @@ void LogicGateNode::update(SceneInfo* sceneInfo) } } -void LogicGateNode::createOrUpdateGeometry(SceneInfo* sceneInfo) +void LogicGateNode::createOrUpdateGeometry(SceneInfo*) { if (!mPrimaryPath) { diff --git a/plugins/circuits/src/visuals/TerminalNode.cpp b/plugins/circuits/src/visuals/TerminalNode.cpp index 0fde36e..4feb0f8 100644 --- a/plugins/circuits/src/visuals/TerminalNode.cpp +++ b/plugins/circuits/src/visuals/TerminalNode.cpp @@ -13,7 +13,7 @@ void TerminalNode::setContent(Terminal* terminal) mContent = terminal; } -void TerminalNode::createOrUpdateGeometry(SceneInfo* sceneInfo) +void TerminalNode::createOrUpdateGeometry(SceneInfo*) { if (!mMarker) { @@ -32,4 +32,4 @@ void TerminalNode::update(SceneInfo* sceneInfo) createOrUpdateGeometry(sceneInfo); mContentDirty = false; } -} \ No newline at end of file +} diff --git a/plugins/music/src/midi/reader/MidiMetaEventAdapter.cpp b/plugins/music/src/midi/reader/MidiMetaEventAdapter.cpp index 79d2233..5e475a6 100644 --- a/plugins/music/src/midi/reader/MidiMetaEventAdapter.cpp +++ b/plugins/music/src/midi/reader/MidiMetaEventAdapter.cpp @@ -129,7 +129,7 @@ int MidiMetaEventAdapter::ReadChannelPrefixEvent(std::ifstream* file, MetaMidiEv return byteCount; } -int MidiMetaEventAdapter::ReadTimeSignatureEvent(std::ifstream* file, MetaMidiEvent* event) +int MidiMetaEventAdapter::ReadTimeSignatureEvent(std::ifstream* file, MetaMidiEvent*) { unsigned byteCount = 0; int length = *BinaryStream::getNextByteAsInt(file); @@ -154,7 +154,7 @@ int MidiMetaEventAdapter::ReadTimeSignatureEvent(std::ifstream* file, MetaMidiEv return byteCount; } -int MidiMetaEventAdapter::ReadKeySignatureEvent(std::ifstream* file, MetaMidiEvent* event) +int MidiMetaEventAdapter::ReadKeySignatureEvent(std::ifstream* file, MetaMidiEvent*) { unsigned byteCount = 0; int length = *BinaryStream::getNextByteAsInt(file); @@ -168,7 +168,7 @@ int MidiMetaEventAdapter::ReadKeySignatureEvent(std::ifstream* file, MetaMidiEve return byteCount; } -int MidiMetaEventAdapter::ReadTimeCodeEvent(std::ifstream* file, MetaMidiEvent* event) +int MidiMetaEventAdapter::ReadTimeCodeEvent(std::ifstream* file, MetaMidiEvent*) { unsigned byteCount = 0; int length = *BinaryStream::getNextByteAsInt(file); diff --git a/plugins/quantum_computing/src/visuals/BlochSphereNode.cpp b/plugins/quantum_computing/src/visuals/BlochSphereNode.cpp index 14b4b62..3883f88 100644 --- a/plugins/quantum_computing/src/visuals/BlochSphereNode.cpp +++ b/plugins/quantum_computing/src/visuals/BlochSphereNode.cpp @@ -4,52 +4,52 @@ #include "LineNode.h" BlochSphereNode::BlochSphereNode(const Point& location) - : AbstractVisualNode(location, "BlochSphereNode") + : AbstractVisualNode(location, "BlochSphereNode") { } void BlochSphereNode::setContent(BlochSphere* content) { - mContent = content; - mContentDirty = true; + mContent = content; + mContentDirty = true; } void BlochSphereNode::setSize(double size) { - if (size != mSize) - { - mSize = size; - mContentDirty = true; - } + if (size != mSize) + { + mSize = size; + mContentDirty = true; + } } -void BlochSphereNode::update(SceneInfo* sceneInfo) +void BlochSphereNode::update(SceneInfo*) { - if (!mContentDirty) - { - return; - } + if (!mContentDirty) + { + return; + } - mChildren.clear(); + mChildren.clear(); - auto loc = Point(mSize / 2.0, mSize / 2.0); - mInnerCircle = std::make_unique(loc, mSize / 2.0); - mInnerCircle->setMinorRadius(mSize / 4.0); - mInnerCircle->setStrokeThickness(0.5); + auto loc = Point(mSize / 2.0, mSize / 2.0); + mInnerCircle = std::make_unique(loc, mSize / 2.0); + mInnerCircle->setMinorRadius(mSize / 4.0); + mInnerCircle->setStrokeThickness(0.5); - mOuterCircle = std::make_unique(loc, mSize/2.0); + mOuterCircle = std::make_unique(loc, mSize/2.0); - const auto end_point_x = Point(loc.getX() + 1.2 * mSize / 2.0, loc.getY()); - const std::vector points{end_point_x }; - mXAxis = std::make_unique(loc, points); + const auto end_point_x = Point(loc.getX() + 1.2 * mSize / 2.0, loc.getY()); + const std::vector points{end_point_x }; + mXAxis = std::make_unique(loc, points); - mCentreCircle = std::make_unique(loc, mSize / 50.0); - mCentreCircle->setFillColor(Color(0, 0, 0)); - mCentreCircle->setHasStrokeColor(false); + mCentreCircle = std::make_unique(loc, mSize / 50.0); + mCentreCircle->setFillColor(Color(0, 0, 0)); + mCentreCircle->setHasStrokeColor(false); - addChild(mInnerCircle.get()); - addChild(mOuterCircle.get()); - addChild(mXAxis.get()); - addChild(mCentreCircle.get()); -} \ No newline at end of file + addChild(mInnerCircle.get()); + addChild(mOuterCircle.get()); + addChild(mXAxis.get()); + addChild(mCentreCircle.get()); +} diff --git a/src/base/compiler/template_engine/TemplateElements.cpp b/src/base/compiler/template_engine/TemplateElements.cpp index 422143b..46e6577 100644 --- a/src/base/compiler/template_engine/TemplateElements.cpp +++ b/src/base/compiler/template_engine/TemplateElements.cpp @@ -113,7 +113,7 @@ const std::string& TemplateExpression::getContent() const return mContent; } -std::string TemplateExpression::render(TemplateSubstitutionContext* substitutions, TemplateNode* parentContext) +std::string TemplateExpression::render(TemplateSubstitutionContext* substitutions, TemplateNode*) { if (substitutions && substitutions->hasSubstitution(mContent)) { @@ -143,7 +143,7 @@ bool TemplateTextBody::hasContent() const return !mContent.empty(); } -std::string TemplateTextBody::render(TemplateSubstitutionContext* substitutions, TemplateNode* parentContext) +std::string TemplateTextBody::render(TemplateSubstitutionContext*, TemplateNode*) { std::string content; for(unsigned idx=0; idx args) mWorkingNode = temp; } -void TemplateFile::onFoundEndBlock(const std::vector args) +void TemplateFile::onFoundEndBlock(const std::vector) { mWorkingNode = mWorkingNode->getParent(); } diff --git a/src/base/compression/huffman/HuffmanEncoder.cpp b/src/base/compression/huffman/HuffmanEncoder.cpp index 023012f..6c154ec 100644 --- a/src/base/compression/huffman/HuffmanEncoder.cpp +++ b/src/base/compression/huffman/HuffmanEncoder.cpp @@ -107,7 +107,7 @@ void HuffmanEncoder::setUseFixedCode(bool useFixed) mUseFixedCode = useFixed; } -uint32_t HuffmanEncoder::getLengthValue(unsigned length) +uint32_t HuffmanEncoder::getLengthValue(unsigned) { return 0; } diff --git a/src/base/compression/huffman/HuffmanStream.cpp b/src/base/compression/huffman/HuffmanStream.cpp index 269fc85..45de3f6 100644 --- a/src/base/compression/huffman/HuffmanStream.cpp +++ b/src/base/compression/huffman/HuffmanStream.cpp @@ -77,7 +77,7 @@ bool HuffmanStream::readNextDistanceSymbol(unsigned& buffer) return true; } -void HuffmanStream::addValue(unsigned value, unsigned& count, unsigned& lastValue, std::vector& literals, unsigned numLiterals, std::vector& distances) +void HuffmanStream::addValue(unsigned value, unsigned& count, unsigned& lastValue, std::vector& literals, unsigned, std::vector& distances) { if (count < mNumLiterals) { diff --git a/src/base/core/CommandLineArgs.cpp b/src/base/core/CommandLineArgs.cpp index dcc35a5..26ef06c 100644 --- a/src/base/core/CommandLineArgs.cpp +++ b/src/base/core/CommandLineArgs.cpp @@ -29,6 +29,8 @@ void CommandLineArgs::initialize(CommandLineArgs* args) ::LocalFree(szArglist); args->process(windowsArgs); +#else + (void)args; #endif } diff --git a/src/base/core/file_utilities/File.cpp b/src/base/core/file_utilities/File.cpp index 207dfeb..e09fc47 100644 --- a/src/base/core/file_utilities/File.cpp +++ b/src/base/core/file_utilities/File.cpp @@ -36,7 +36,7 @@ std::string File::dumpBinary() const unsigned char val = static_cast(mInHandle->get()); const unsigned char ascii_val = std::isalpha(val) ? val : '.'; sstr << count << " | " << ByteUtils::toString(val) << " | " << static_cast(val) << " | " << ascii_val << '\n'; - if (count < 0 && count % 10 == 0) + if (count % 10 == 0) { sstr << "\n"; } diff --git a/src/base/core/loggers/FileLogger.cpp b/src/base/core/loggers/FileLogger.cpp index 6c2878a..d9330b9 100644 --- a/src/base/core/loggers/FileLogger.cpp +++ b/src/base/core/loggers/FileLogger.cpp @@ -62,7 +62,7 @@ void FileLogger::LogLine(const std::string& logType, const std::ostringstream& l std::time_t t = std::time(nullptr); const std::string cleanedFileName = fileName.substr(fileName.find_last_of("/\\") + 1); - std::tm time_buf = { 0 }; + std::tm time_buf{ }; #ifdef WIN32 gmtime_s(&time_buf, &t); #else diff --git a/src/base/core/streams/InputBitStream.h b/src/base/core/streams/InputBitStream.h index 302c047..03d3fb1 100644 --- a/src/base/core/streams/InputBitStream.h +++ b/src/base/core/streams/InputBitStream.h @@ -16,7 +16,7 @@ class InputBitStream : public BitStream void writeByte(unsigned char data, bool checkOverflow = true) override; - void writeBytes(const std::vector data) override + void writeBytes(const std::vector) override { } diff --git a/src/base/database/database_interfaces/SqliteInterface.cpp b/src/base/database/database_interfaces/SqliteInterface.cpp index 5de71f3..c65c998 100644 --- a/src/base/database/database_interfaces/SqliteInterface.cpp +++ b/src/base/database/database_interfaces/SqliteInterface.cpp @@ -29,7 +29,7 @@ void SqliteInterface::open(Database* db) } } -static int callback(void *NotUsed, int argc, char **argv, char **azColName) +static int callback(void *, int argc, char **, char **) { for(int i=0; i* grid) const +void Arc::sample(SparseGrid*) const { } @@ -77,4 +77,4 @@ Arc::Type Arc::getType() const Arc::CurveType Arc::getCurveType() const { return CurveType::ARC; -} \ No newline at end of file +} diff --git a/src/base/geometry/path/Arc.h b/src/base/geometry/path/Arc.h index 377ab64..f2b93ac 100644 --- a/src/base/geometry/path/Arc.h +++ b/src/base/geometry/path/Arc.h @@ -20,7 +20,7 @@ public: CurveType getCurveType() const override; - void sample(SparseGrid* grid) const override; + void sample(SparseGrid*) const override; std::string toPostScriptString(std::size_t precision = 0) const override; @@ -32,4 +32,4 @@ private: double mRotation{ 0 }; bool mLargeArc{ false }; bool mSweep{ false }; -}; \ No newline at end of file +}; diff --git a/src/base/geometry/path/CubicBezierCurve.cpp b/src/base/geometry/path/CubicBezierCurve.cpp index 7590ceb..793ff8c 100644 --- a/src/base/geometry/path/CubicBezierCurve.cpp +++ b/src/base/geometry/path/CubicBezierCurve.cpp @@ -49,7 +49,7 @@ const Point& CubicBezierCurve::getLocation() const return mStartPoint; } -void CubicBezierCurve::sample(SparseGrid* grid) const +void CubicBezierCurve::sample(SparseGrid*) const { } @@ -62,4 +62,4 @@ CubicBezierCurve::Type CubicBezierCurve::getType() const CubicBezierCurve::CurveType CubicBezierCurve::getCurveType() const { return CurveType::CUBIC_BEZIER; -} \ No newline at end of file +} diff --git a/src/base/geometry/path/CubicBezierCurve.h b/src/base/geometry/path/CubicBezierCurve.h index e081198..b3d4043 100644 --- a/src/base/geometry/path/CubicBezierCurve.h +++ b/src/base/geometry/path/CubicBezierCurve.h @@ -20,7 +20,7 @@ public: CurveType getCurveType() const override; - void sample(SparseGrid* grid) const override; + void sample(SparseGrid*) const override; std::string toPostScriptString(std::size_t precision = 0) const override; @@ -29,4 +29,4 @@ private: Point mEndPoint; Point mStartControlPoint; Point mEndControlPoint; -}; \ No newline at end of file +}; diff --git a/src/base/geometry/path/Curve.h b/src/base/geometry/path/Curve.h index 9c39946..804fcae 100644 --- a/src/base/geometry/path/Curve.h +++ b/src/base/geometry/path/Curve.h @@ -5,13 +5,13 @@ class Curve : public PathElement { public: - enum class CurveType - { - ARC, - QUADRATIC_BEZIER, - CUBIC_BEZIER, - UNKNOWN - }; + enum class CurveType + { + ARC, + QUADRATIC_BEZIER, + CUBIC_BEZIER, + UNKNOWN + }; - virtual CurveType getCurveType() const = 0; -}; \ No newline at end of file + virtual CurveType getCurveType() const = 0; +}; diff --git a/src/base/geometry/path/Line.h b/src/base/geometry/path/Line.h index 8d22264..e4c4143 100644 --- a/src/base/geometry/path/Line.h +++ b/src/base/geometry/path/Line.h @@ -9,37 +9,37 @@ class Line : public PathElement { public: - enum class InputBufferType - { - HORIZONTAL_REL, - HORIZONTAL_ABS, - VERTICAL_REL, - VERTICAL_ABS, - XY_REL, - XY_ABS - }; + enum class InputBufferType + { + HORIZONTAL_REL, + HORIZONTAL_ABS, + VERTICAL_REL, + VERTICAL_ABS, + XY_REL, + XY_ABS + }; - Line(const Point& start, const PointCollection& points); + Line(const Point& start, const PointCollection& points); - Line(const Point& start, InputBufferType bufferType, const std::vector& buffer); + Line(const Point& start, InputBufferType bufferType, const std::vector& buffer); - const PointCollection& getPoints() const; + const PointCollection& getPoints() const; - Line::Type getType() const override; + Line::Type getType() const override; - const Point& getLocation() const override; + const Point& getLocation() const override; - Bounds getBounds() const override; + Bounds getBounds() const override; - Point getFirstPoint() const override; + Point getFirstPoint() const override; - Point getEndPoint() const override; + Point getEndPoint() const override; - void sample(SparseGrid* grid) const override {}; + void sample(SparseGrid*) const override {}; - std::string toPostScriptString(std::size_t precision = 0) const override; + std::string toPostScriptString(std::size_t precision = 0) const override; private: - Point mStartPoint; - PointCollection mPoints; -}; \ No newline at end of file + Point mStartPoint; + PointCollection mPoints; +}; diff --git a/src/base/geometry/path/LineSegment.cpp b/src/base/geometry/path/LineSegment.cpp index a1ab353..73c294b 100644 --- a/src/base/geometry/path/LineSegment.cpp +++ b/src/base/geometry/path/LineSegment.cpp @@ -29,7 +29,7 @@ const Point& LineSegment::getPoint1() const return mP1; } -void LineSegment::sample(SparseGrid* grid) const +void LineSegment::sample(SparseGrid*) const { } diff --git a/src/base/geometry/path/LineSegment.h b/src/base/geometry/path/LineSegment.h index 67d200f..6c9a9e2 100644 --- a/src/base/geometry/path/LineSegment.h +++ b/src/base/geometry/path/LineSegment.h @@ -31,7 +31,7 @@ public: bool isVertical() const; - void sample(SparseGrid* grid) const override; + void sample(SparseGrid*) const override; std::string toPostScriptString(std::size_t precision = 0) const override; diff --git a/src/base/geometry/path/Path.cpp b/src/base/geometry/path/Path.cpp index b8e2510..67455d0 100644 --- a/src/base/geometry/path/Path.cpp +++ b/src/base/geometry/path/Path.cpp @@ -43,7 +43,7 @@ GeometryPath::Type GeometryPath::getType() const return GeometryPath::Type::PATH; } -void GeometryPath::sample(SparseGrid* grid) const +void GeometryPath::sample(SparseGrid*) const { } @@ -52,4 +52,4 @@ std::string GeometryPath::getAsPostScript() const { PathPostScriptConverter converter; return converter.toPostScript(this); -} \ No newline at end of file +} diff --git a/src/base/geometry/path/Path.h b/src/base/geometry/path/Path.h index 67b0de0..e81a6a3 100644 --- a/src/base/geometry/path/Path.h +++ b/src/base/geometry/path/Path.h @@ -11,53 +11,53 @@ using PathElementPtr = std::unique_ptr; class GeometryPathFeature { public: - void addElement(PathElementPtr element) - { - if (mElements.empty()) - { - mLocation = element->getFirstPoint(); - } - mElements.push_back(std::move(element)); - } + void addElement(PathElementPtr element) + { + if (mElements.empty()) + { + mLocation = element->getFirstPoint(); + } + mElements.push_back(std::move(element)); + } - const Point& getLocation() const - { - return mLocation; - } + const Point& getLocation() const + { + return mLocation; + } - const std::vector& getElements() const - { - return mElements; - } + const std::vector& getElements() const + { + return mElements; + } private: - Point mLocation; - std::vector mElements; + Point mLocation; + std::vector mElements; }; using GeometryPathFeaturePtr = std::unique_ptr; class GeometryPath : public AbstractGeometricItem { public: - ~GeometryPath(); + ~GeometryPath(); - void addFeature(GeometryPathFeaturePtr feature); + void addFeature(GeometryPathFeaturePtr feature); - void buildFromPostscript(const std::string& psString); + void buildFromPostscript(const std::string& psString); - std::string getAsPostScript() const; + std::string getAsPostScript() const; - const Point& getLocation() const override; + const Point& getLocation() const override; - Bounds getBounds() const override; + Bounds getBounds() const override; - Type getType() const override; + Type getType() const override; - const std::vector& getFeatures() const; + const std::vector& getFeatures() const; - void sample(SparseGrid* grid) const override; + void sample(SparseGrid*) const override; private: - Point mLocation; - std::vector mFeatures; -}; \ No newline at end of file + Point mLocation; + std::vector mFeatures; +}; diff --git a/src/base/geometry/path/PathElement.h b/src/base/geometry/path/PathElement.h index c1abdeb..215aeb3 100644 --- a/src/base/geometry/path/PathElement.h +++ b/src/base/geometry/path/PathElement.h @@ -7,25 +7,25 @@ class PathElement : public AbstractGeometricItem { public: - enum class PostscriptPositioning - { - RELATIVE_TO, - ABSOLUTE_TO - }; + enum class PostscriptPositioning + { + RELATIVE_TO, + ABSOLUTE_TO + }; - ~PathElement(); + ~PathElement(); - virtual Point getFirstPoint() const = 0; + virtual Point getFirstPoint() const = 0; - virtual Point getEndPoint() const = 0; + virtual Point getEndPoint() const = 0; - void setPostscriptPositioning(PostscriptPositioning positioning) - { - mPostscriptPositioning = positioning; - } + void setPostscriptPositioning(PostscriptPositioning positioning) + { + mPostscriptPositioning = positioning; + } - virtual std::string toPostScriptString(std::size_t precision = 0) const = 0; + virtual std::string toPostScriptString(std::size_t precision = 0) const = 0; protected: - PostscriptPositioning mPostscriptPositioning{ PostscriptPositioning::RELATIVE_TO}; -}; \ No newline at end of file + PostscriptPositioning mPostscriptPositioning{ PostscriptPositioning::RELATIVE_TO}; +}; diff --git a/src/base/geometry/path/QuadraticBezierCurve.cpp b/src/base/geometry/path/QuadraticBezierCurve.cpp index 1159f44..dba241e 100644 --- a/src/base/geometry/path/QuadraticBezierCurve.cpp +++ b/src/base/geometry/path/QuadraticBezierCurve.cpp @@ -42,7 +42,7 @@ const Point& QuadraticBezierCurve::getLocation() const return mStartPoint; } -void QuadraticBezierCurve::sample(SparseGrid* grid) const +void QuadraticBezierCurve::sample(SparseGrid*) const { } @@ -55,4 +55,4 @@ QuadraticBezierCurve::Type QuadraticBezierCurve::getType() const QuadraticBezierCurve::CurveType QuadraticBezierCurve::getCurveType() const { return CurveType::QUADRATIC_BEZIER; -} \ No newline at end of file +} diff --git a/src/base/geometry/path/QuadraticBezierCurve.h b/src/base/geometry/path/QuadraticBezierCurve.h index b742fff..6b68f5c 100644 --- a/src/base/geometry/path/QuadraticBezierCurve.h +++ b/src/base/geometry/path/QuadraticBezierCurve.h @@ -6,26 +6,26 @@ class QuadraticBezierCurve : public Curve { public: - QuadraticBezierCurve(const Point& startPoint, const Point& endPoint, const Point& controlPoint); + QuadraticBezierCurve(const Point& startPoint, const Point& endPoint, const Point& controlPoint); - Point getFirstPoint() const override; + Point getFirstPoint() const override; - Point getEndPoint() const override; + Point getEndPoint() const override; - Bounds getBounds() const override; + Bounds getBounds() const override; - const Point& getLocation() const override; + const Point& getLocation() const override; - Type getType() const override; + Type getType() const override; - CurveType getCurveType() const override; + CurveType getCurveType() const override; - void sample(SparseGrid* grid) const override; + void sample(SparseGrid*) const override; - std::string toPostScriptString(std::size_t precision = 0) const override; + std::string toPostScriptString(std::size_t precision = 0) const override; private: - Point mStartPoint; - Point mEndPoint; - Point mControlPoint; -}; \ No newline at end of file + Point mStartPoint; + Point mEndPoint; + Point mControlPoint; +}; diff --git a/src/base/geometry/primitives/Circle.cpp b/src/base/geometry/primitives/Circle.cpp index bc60940..5261e63 100644 --- a/src/base/geometry/primitives/Circle.cpp +++ b/src/base/geometry/primitives/Circle.cpp @@ -28,7 +28,7 @@ void Circle::setMinorRadius(double radius) mMinorRadius = radius; } -void Circle::sample(SparseGrid* grid) const +void Circle::sample(SparseGrid*) const { } diff --git a/src/base/geometry/primitives/Circle.h b/src/base/geometry/primitives/Circle.h index 088fd18..3b69bb0 100644 --- a/src/base/geometry/primitives/Circle.h +++ b/src/base/geometry/primitives/Circle.h @@ -22,7 +22,7 @@ public: void setMinorRadius(double radius); - void sample(SparseGrid* grid) const override; + void sample(SparseGrid*) const override; private: double mMinorRadius{ 0.5 }; diff --git a/src/base/geometry/primitives/Rectangle.cpp b/src/base/geometry/primitives/Rectangle.cpp index 1f89f5e..0c38e44 100644 --- a/src/base/geometry/primitives/Rectangle.cpp +++ b/src/base/geometry/primitives/Rectangle.cpp @@ -32,7 +32,7 @@ namespace ntk { return { minX , maxX , minY , maxY }; } - void Rectangle::sample(SparseGrid* grid) const + void Rectangle::sample(SparseGrid*) const { } diff --git a/src/base/geometry/primitives/Rectangle.h b/src/base/geometry/primitives/Rectangle.h index 5f0babd..2961db4 100644 --- a/src/base/geometry/primitives/Rectangle.h +++ b/src/base/geometry/primitives/Rectangle.h @@ -23,7 +23,7 @@ public: void setRadius(double radius); - void sample(SparseGrid* grid) const override; + void sample(SparseGrid*) const override; private: Point mBottomLeft; diff --git a/src/base/network/NetworkManager.cpp b/src/base/network/NetworkManager.cpp index 052de40..223fdc5 100644 --- a/src/base/network/NetworkManager.cpp +++ b/src/base/network/NetworkManager.cpp @@ -37,6 +37,8 @@ void NetworkManager::runHttpServer(AbstractWebApp* webApp) server.initialize(); server.run(); #else + (void)webApp; + if (!mSocketInterface) { initialize(); diff --git a/src/media/audio/audio_interfaces/AlsaInterface.cpp b/src/media/audio/audio_interfaces/AlsaInterface.cpp index a6a1b87..7df0c53 100644 --- a/src/media/audio/audio_interfaces/AlsaInterface.cpp +++ b/src/media/audio/audio_interfaces/AlsaInterface.cpp @@ -58,7 +58,7 @@ void AlsaInterface::openDevice(AudioDevice* device) } } -void AlsaInterface::setAccessType(AudioDevice* device) +void AlsaInterface::setAccessType(AudioDevice*) { if (snd_pcm_hw_params_set_access(mHandle, mHardwareParams, SND_PCM_ACCESS_RW_INTERLEAVED) < 0) { @@ -67,7 +67,7 @@ void AlsaInterface::setAccessType(AudioDevice* device) } } -bool AlsaInterface::setSampleFormat(AudioDevice* device) +bool AlsaInterface::setSampleFormat(AudioDevice*) { /* Set sample format */ if (snd_pcm_hw_params_set_format(mHandle, mHardwareParams, SND_PCM_FORMAT_S16_LE) < 0) diff --git a/src/media/image/ImageBitStream.cpp b/src/media/image/ImageBitStream.cpp index eee5faa..a53df70 100644 --- a/src/media/image/ImageBitStream.cpp +++ b/src/media/image/ImageBitStream.cpp @@ -14,7 +14,7 @@ bool ImageBitStream::isFinished() const return mByteOffset == static_cast(mImage->getGrid()->getDataSize()); } -std::vector ImageBitStream::peekNextNBytes(unsigned n) const +std::vector ImageBitStream::peekNextNBytes(unsigned) const { return {}; } @@ -32,7 +32,7 @@ std::optional ImageBitStream::readNextByte() return {}; } -void ImageBitStream::writeByte(unsigned char data, bool checkOverflow ) +void ImageBitStream::writeByte(unsigned char, bool ) { mByteOffset++; diff --git a/src/media/image/ImageBitStream.h b/src/media/image/ImageBitStream.h index 1cd90ad..0ad286d 100644 --- a/src/media/image/ImageBitStream.h +++ b/src/media/image/ImageBitStream.h @@ -17,7 +17,7 @@ public: void writeByte(unsigned char data, bool checkOverflow = true) override; - void writeBytes(const std::vector data) override + void writeBytes(const std::vector) override { } diff --git a/src/rendering/fonts/FontsManager.cpp b/src/rendering/fonts/FontsManager.cpp index dfb7fbb..3adbcf7 100644 --- a/src/rendering/fonts/FontsManager.cpp +++ b/src/rendering/fonts/FontsManager.cpp @@ -34,7 +34,7 @@ IFontEngine* FontsManager::getFontEngine() const return mFontEngine.get(); } -FontGlyph* FontsManager::getGlyph(const std::string& fontFace, float size, uint32_t c) +FontGlyph* FontsManager::getGlyph(const std::string&, float size, uint32_t c) { auto path = std::filesystem::path("truetype/liberation/LiberationSans-Regular.ttf"); diff --git a/src/rendering/graphics/DrawingSurface.cpp b/src/rendering/graphics/DrawingSurface.cpp index 85393cf..7869a07 100644 --- a/src/rendering/graphics/DrawingSurface.cpp +++ b/src/rendering/graphics/DrawingSurface.cpp @@ -15,7 +15,7 @@ std::unique_ptr DrawingSurface::Create() return std::make_unique(); } -void DrawingSurface::setSize(unsigned width, unsigned height, bool triggerResize) +void DrawingSurface::setSize(unsigned width, unsigned height, bool) { mWidth = width; mHeight = height; diff --git a/src/rendering/mesh/AbstractMesh.cpp b/src/rendering/mesh/AbstractMesh.cpp index 8924cdc..91b4db7 100644 --- a/src/rendering/mesh/AbstractMesh.cpp +++ b/src/rendering/mesh/AbstractMesh.cpp @@ -1,6 +1,6 @@ #include "AbstractMesh.h" -void AbstractMesh::addConstantNodeVectorAttribute(const std::string& tag, const std::vector& values) +void AbstractMesh::addConstantNodeVectorAttribute(const std::string&, const std::vector&) { } @@ -10,7 +10,7 @@ AbstractMesh::~AbstractMesh() } -std::vector > AbstractMesh::getNodeVectorAttributes(const std::string& tag) +std::vector > AbstractMesh::getNodeVectorAttributes(const std::string&) { std::vector > attribs(mNodes.size()); return attribs; diff --git a/src/rendering/mesh/MeshPrimitives.cpp b/src/rendering/mesh/MeshPrimitives.cpp index a8db7f8..5b80e26 100644 --- a/src/rendering/mesh/MeshPrimitives.cpp +++ b/src/rendering/mesh/MeshPrimitives.cpp @@ -101,7 +101,7 @@ std::unique_ptr MeshPrimitives::buildCircleAsLineMesh(std::size_t numS return MeshBuilder::buildLineMesh(locations, edge_ids); } -std::unique_ptr MeshPrimitives::buildRoundedRectangleAsTriMesh(double radius, double aspect_ratio, std::size_t num_segments) +std::unique_ptr MeshPrimitives::buildRoundedRectangleAsTriMesh(double radius, double, std::size_t num_segments) { std::size_t num_fans = 4; std::size_t num_nodes_per_fan = num_segments + 2; diff --git a/src/rendering/visual_elements/nodes/AbstractVisualNode.cpp b/src/rendering/visual_elements/nodes/AbstractVisualNode.cpp index c75ebfa..6978480 100644 --- a/src/rendering/visual_elements/nodes/AbstractVisualNode.cpp +++ b/src/rendering/visual_elements/nodes/AbstractVisualNode.cpp @@ -29,7 +29,7 @@ std::size_t AbstractVisualNode::getNumSceneItems() const return mSceneItems.size(); } -void AbstractVisualNode::update(SceneInfo* sceneInfo) +void AbstractVisualNode::update(SceneInfo*) { } diff --git a/src/rendering/visual_elements/nodes/GridNode.cpp b/src/rendering/visual_elements/nodes/GridNode.cpp index 03b9831..f6837ac 100644 --- a/src/rendering/visual_elements/nodes/GridNode.cpp +++ b/src/rendering/visual_elements/nodes/GridNode.cpp @@ -76,7 +76,7 @@ std::size_t GridNode::getNumSceneItems() const return 2; } -void GridNode::update(SceneInfo* sceneInfo) +void GridNode::update(SceneInfo*) { if (!mBackgroundModel || mDataDirty) { diff --git a/src/rendering/visual_elements/nodes/MeshNode.cpp b/src/rendering/visual_elements/nodes/MeshNode.cpp index 0b9924d..d1b8891 100644 --- a/src/rendering/visual_elements/nodes/MeshNode.cpp +++ b/src/rendering/visual_elements/nodes/MeshNode.cpp @@ -14,7 +14,7 @@ MeshNode::~MeshNode() } -SceneItem* MeshNode::getSceneItem(std::size_t idx) const +SceneItem* MeshNode::getSceneItem(std::size_t) const { return mModel.get(); } @@ -55,7 +55,7 @@ void MeshNode::setMesh(AbstractMesh* mesh) mMeshIsDirty = true; } -void MeshNode::update(SceneInfo* sceneInfo) +void MeshNode::update(SceneInfo*) { if (!mModel || mMeshIsDirty) { diff --git a/src/rendering/visual_elements/scene/Scene.cpp b/src/rendering/visual_elements/scene/Scene.cpp index 6fdeec5..967a835 100644 --- a/src/rendering/visual_elements/scene/Scene.cpp +++ b/src/rendering/visual_elements/scene/Scene.cpp @@ -86,7 +86,7 @@ void Scene::setShowMeshOutline(bool shouldShow) mSceneInfo->mShowMeshOutline = shouldShow; } -void Scene::setSupportsGeometryPrimitives(bool supports) +void Scene::setSupportsGeometryPrimitives(bool) { mSceneInfo->mSupportsGeometryPrimitives = true; } diff --git a/src/rendering/visual_elements/svg/SvgNode.cpp b/src/rendering/visual_elements/svg/SvgNode.cpp index c8bb98e..04f300a 100644 --- a/src/rendering/visual_elements/svg/SvgNode.cpp +++ b/src/rendering/visual_elements/svg/SvgNode.cpp @@ -31,7 +31,7 @@ unsigned SvgNode::getContentHeight() const return mContentHeight; } -void SvgNode::createOrUpdateGeometry(SceneInfo* sceneInfo) +void SvgNode::createOrUpdateGeometry(SceneInfo*) { if (!mContent->getRoot()) { diff --git a/src/ui/client/TopBar.cpp b/src/ui/client/TopBar.cpp index 07b328d..a3b4d01 100644 --- a/src/ui/client/TopBar.cpp +++ b/src/ui/client/TopBar.cpp @@ -16,7 +16,7 @@ TopBar::TopBar() fileButton->setMargin(2); fileButton->setMaxWidth(60); - auto onClick = [this](Widget* self){ + auto onClick = [this](Widget*){ auto menu = std::make_unique(); auto window = getTopLevelWindow(); window->addPopup(std::move(menu)); diff --git a/src/ui/client/TopBarMenu.h b/src/ui/client/TopBarMenu.h index c213069..f302a95 100644 --- a/src/ui/client/TopBarMenu.h +++ b/src/ui/client/TopBarMenu.h @@ -7,7 +7,7 @@ class TopBarMenu : public Widget { public: - void popupFrom(Widget* parent) + void popupFrom(Widget*) { diff --git a/src/ui/ui_elements/desktop_elements/Keyboard.cpp b/src/ui/ui_elements/desktop_elements/Keyboard.cpp index 758529b..26e7119 100644 --- a/src/ui/ui_elements/desktop_elements/Keyboard.cpp +++ b/src/ui/ui_elements/desktop_elements/Keyboard.cpp @@ -10,12 +10,12 @@ std::unique_ptr Keyboard::Create() return std::make_unique(); } -std::string Keyboard::getKeyString(KeyCode code) +std::string Keyboard::getKeyString(KeyCode) { return ""; } -Keyboard::Function Keyboard::getFunction(KeyCode code) +Keyboard::Function Keyboard::getFunction(KeyCode) { return Function::UNSET; } diff --git a/src/ui/ui_elements/style/FontTokens.cpp b/src/ui/ui_elements/style/FontTokens.cpp index e97f25e..570b242 100644 --- a/src/ui/ui_elements/style/FontTokens.cpp +++ b/src/ui/ui_elements/style/FontTokens.cpp @@ -4,61 +4,61 @@ std::string FontTokens::getFont(Theme::Ref::Typeface::Font font) { - switch (font) - { - case Theme::Ref::Typeface::Font::Brand: - return "Segoe UI"; - case Theme::Ref::Typeface::Font::Plain: - return "Segoe UI"; - default: - return "Segoe UI"; - } + switch (font) + { + case Theme::Ref::Typeface::Font::Brand: + return "Segoe UI"; + case Theme::Ref::Typeface::Font::Plain: + return "Segoe UI"; + default: + return "Segoe UI"; + } } Theme::Ref::Typeface::Font FontTokens::getFont(Theme::Sys::Typescale typescale) { - switch (typescale) - { - case Theme::Sys::Typescale::Label_Large: - return Theme::Ref::Typeface::Font::Brand; - default: - return Theme::Ref::Typeface::Font::Brand; - } + switch (typescale) + { + case Theme::Sys::Typescale::Label_Large: + return Theme::Ref::Typeface::Font::Brand; + default: + return Theme::Ref::Typeface::Font::Brand; + } } unsigned FontTokens::getLineHeight(Theme::Sys::Typescale typescale) { - switch (typescale) - { - case Theme::Sys::Typescale::Label_Large: - return 67; - default: - return 67; - } + switch (typescale) + { + case Theme::Sys::Typescale::Label_Large: + return 67; + default: + return 67; + } } unsigned FontTokens::getSize(Theme::Sys::Typescale typescale) { - switch (typescale) - { - case Theme::Sys::Typescale::Label_Large: - return static_cast(57/3.5); - default: - return 57; - } + switch (typescale) + { + case Theme::Sys::Typescale::Label_Large: + return static_cast(57/3.5); + default: + return 57; + } } -unsigned FontTokens::getTracking(Theme::Sys::Typescale typescale) +unsigned FontTokens::getTracking(Theme::Sys::Typescale) { - return 0; + return 0; } -unsigned FontTokens::getWeight(Theme::Ref::Typeface::Font font) +unsigned FontTokens::getWeight(Theme::Ref::Typeface::Font) { - return 0; + return 0; } -Theme::Ref::Typeface::Font FontTokens::getWeight(Theme::Sys::Typescale typescale) +Theme::Ref::Typeface::Font FontTokens::getWeight(Theme::Sys::Typescale) { - return Theme::Ref::Typeface::Font::Brand; -} \ No newline at end of file + return Theme::Ref::Typeface::Font::Brand; +} diff --git a/src/ui/ui_elements/widgets/Widget.cpp b/src/ui/ui_elements/widgets/Widget.cpp index e717c0a..50eab76 100644 --- a/src/ui/ui_elements/widgets/Widget.cpp +++ b/src/ui/ui_elements/widgets/Widget.cpp @@ -243,7 +243,7 @@ bool Widget::onKeyboardEvent(const KeyboardEvent* event) return true; } -bool Widget::onMyKeyboardEvent(const KeyboardEvent* event) +bool Widget::onMyKeyboardEvent(const KeyboardEvent*) { return false; } @@ -306,7 +306,7 @@ void Widget::setFocus(bool hasFocus) } } -void Widget::onMyMouseEvent(const MouseEvent* event) +void Widget::onMyMouseEvent(const MouseEvent*) { } diff --git a/src/ui/windows/ui_interfaces/NullUiInterface.h b/src/ui/windows/ui_interfaces/NullUiInterface.h index 8550641..ef5bb05 100644 --- a/src/ui/windows/ui_interfaces/NullUiInterface.h +++ b/src/ui/windows/ui_interfaces/NullUiInterface.h @@ -17,9 +17,9 @@ public: void loop() override{}; - void showWindow(mt::Window* window) override{}; + void showWindow(mt::Window*) override{}; - void addWindow(mt::Window* window) override{}; + void addWindow(mt::Window*) override{}; protected: void initialize() override{}; diff --git a/src/ui/windows/ui_interfaces/x11/XcbGlWindowInterface.cpp b/src/ui/windows/ui_interfaces/x11/XcbGlWindowInterface.cpp index 8e5ef02..b37bf15 100644 --- a/src/ui/windows/ui_interfaces/x11/XcbGlWindowInterface.cpp +++ b/src/ui/windows/ui_interfaces/x11/XcbGlWindowInterface.cpp @@ -73,7 +73,7 @@ bool XcbGlWindowInterface::initialize(xcb_window_t window) return true; } -void XcbGlWindowInterface::resizeViewPort(unsigned width, unsigned height) +void XcbGlWindowInterface::resizeViewPort(unsigned, unsigned) { //glViewport(0, 0, width, height); //glScissor(0, 0, width, height); diff --git a/src/ui/windows/ui_interfaces/x11/XcbInterface.cpp b/src/ui/windows/ui_interfaces/x11/XcbInterface.cpp index e84b3aa..77d10e1 100644 --- a/src/ui/windows/ui_interfaces/x11/XcbInterface.cpp +++ b/src/ui/windows/ui_interfaces/x11/XcbInterface.cpp @@ -190,7 +190,7 @@ void XcbInterface::onPaint() mainWindow->doPaint(defaultScreen); } -void XcbInterface::onExposeEvent(xcb_expose_event_t* event) +void XcbInterface::onExposeEvent(xcb_expose_event_t*) { //auto window = mWindows[event->window]; //window->SetSize(event->width, event->height); diff --git a/src/ui/windows/ui_interfaces/x11/XcbWindow.cpp b/src/ui/windows/ui_interfaces/x11/XcbWindow.cpp index 66f1177..9b8bdca 100644 --- a/src/ui/windows/ui_interfaces/x11/XcbWindow.cpp +++ b/src/ui/windows/ui_interfaces/x11/XcbWindow.cpp @@ -30,7 +30,7 @@ XcbWindow::~XcbWindow() xcb_destroy_window(mConnection, mHandle); } -void XcbWindow::add(mt::Window* window, xcb_connection_t* connection, mt::Screen* screen, uint32_t eventMask, FontsManager* fontsManager, XcbGlInterface* xcbGlInterface) +void XcbWindow::add(mt::Window* window, xcb_connection_t* connection, mt::Screen* screen, uint32_t eventMask, FontsManager*, XcbGlInterface* xcbGlInterface) { if (!screen) { diff --git a/src/web/html/HtmlTextRun.h b/src/web/html/HtmlTextRun.h index 46ed8a7..60bdbda 100644 --- a/src/web/html/HtmlTextRun.h +++ b/src/web/html/HtmlTextRun.h @@ -15,7 +15,7 @@ public: return Type::TEXT_RUN; } - std::string toString(unsigned depth = 0, bool keepInline = false) const override + std::string toString(unsigned, bool) const override { return getText(); diff --git a/src/web/html/elements/HtmlParagraphElement.cpp b/src/web/html/elements/HtmlParagraphElement.cpp index 9b961d1..48a1c88 100644 --- a/src/web/html/elements/HtmlParagraphElement.cpp +++ b/src/web/html/elements/HtmlParagraphElement.cpp @@ -1,6 +1,6 @@ #include "HtmlParagraphElement.h" -std::string HtmlParagraphElement::toString(unsigned depth, bool keepInline) const +std::string HtmlParagraphElement::toString(unsigned depth, bool) const { const auto prefix = std::string(2*depth, ' '); diff --git a/src/web/markdown/MarkdownElement.h b/src/web/markdown/MarkdownElement.h index 2b9bde5..0d585fd 100644 --- a/src/web/markdown/MarkdownElement.h +++ b/src/web/markdown/MarkdownElement.h @@ -30,7 +30,7 @@ public: virtual Type getType() const = 0; - virtual void doFieldSubstitution(Type elementType, const std::string& searchPhrase, const std::string& replacementPhrase) + virtual void doFieldSubstitution(Type, const std::string&, const std::string&) { }