jgrogan/stuff-from-scratch
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix up some Release build failures on MSVC.

Browse source
This commit is contained in:
jmsgrogan 2023-01-16 19:36:04 +00:00
parent d370c26c42
commit 2bc53186bc
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/audio/midi/reader/MidiMetaEventAdapter.cpp
View file

@ -68,7 +68,7 @@ int MidiMetaEventAdapter::ReadUnknownEvent(std::ifstream* file)
int length = *BinaryStream::getNextByteAsInt(file); int length = *BinaryStream::getNextByteAsInt(file);
char c; char c;
for(unsigned idx=0; idx<length; idx++) for(int idx=0; idx<length; idx++)
{ {
file->get(c); file->get(c);
} }
@ -144,7 +144,7 @@ int MidiMetaEventAdapter::ReadTimeSignatureEvent(std::ifstream* file, MetaMidiEv
if (length > 4) if (length > 4)
{ {
char c; char c;
for(unsigned idx=0; idx<length-4; idx++) for(int idx=0; idx<length-4; idx++)
{ {
file->get(c); file->get(c);
byteCount++; byteCount++;

8
src/web/markdown/MarkdownParser.cpp
View file

@ -240,11 +240,11 @@ bool MarkdownParser::startsWithMultiLineQuote(const std::string& line) const
int MarkdownParser::startsWithCustomMultilineBlock(const std::string& line) const int MarkdownParser::startsWithCustomMultilineBlock(const std::string& line) const
{ {
for(unsigned idx=0; idx<mWorkingDocument->getNumMultilineContexts(); idx++) for(std::size_t idx=0; idx<mWorkingDocument->getNumMultilineContexts(); idx++)
{ {
if (StringUtils::startsWith(line, mWorkingDocument->getMultilineContext(idx)->getDelimiter(), true)) if (StringUtils::startsWith(line, mWorkingDocument->getMultilineContext(idx)->getDelimiter(), true))
{ {
return idx; return static_cast<int>(idx);
} }
} }
return -1; return -1;
@ -279,7 +279,7 @@ void MarkdownParser::onFoundMultiLineQuote(const std::string& line)
} }
} }
void MarkdownParser::onFoundCustomMultiLineBlock(const std::string& line, unsigned blockSlot) void MarkdownParser::onFoundCustomMultiLineBlock(const std::string& line, std::size_t blockSlot)
{ {
if (mWorkingElement && mWorkingElement->getType() == MarkdownElement::Type::CUSTOM_MULTILINE && blockSlot == mCustomDelimiterIndex) if (mWorkingElement && mWorkingElement->getType() == MarkdownElement::Type::CUSTOM_MULTILINE && blockSlot == mCustomDelimiterIndex)
{ {
@ -309,7 +309,7 @@ void MarkdownParser::onFoundHeading(const std::string& line)
{ {
onSectionFinished(); onSectionFinished();
auto level = StringUtils::countFirstConsecutiveHits(line, HEADING_DELIMITER); auto level = static_cast<unsigned>(StringUtils::countFirstConsecutiveHits(line, HEADING_DELIMITER));
auto heading = std::make_unique<MarkdownHeading>(level); auto heading = std::make_unique<MarkdownHeading>(level);
std::string prefix; std::string prefix;

4
src/web/markdown/MarkdownParser.h
View file

@ -33,7 +33,7 @@ private:
bool isInMultilineBlock() const; bool isInMultilineBlock() const;
void onFoundMultiLineQuote(const std::string& line); void onFoundMultiLineQuote(const std::string& line);
void onFoundCustomMultiLineBlock(const std::string& line, unsigned blockSlot); void onFoundCustomMultiLineBlock(const std::string& line, std::size_t blockSlot);
void onFoundHeading(const std::string& line); void onFoundHeading(const std::string& line);
void onFoundBulletItem(const std::string& line); void onFoundBulletItem(const std::string& line);
@ -48,7 +48,7 @@ private:
bool startsWithHeading(const std::string& line) const; bool startsWithHeading(const std::string& line) const;
bool startsWithBulletItem(const std::string& line) const; bool startsWithBulletItem(const std::string& line) const;
unsigned mCustomDelimiterIndex{0}; std::size_t mCustomDelimiterIndex{0};
MarkdownElement* mWorkingElement{nullptr}; MarkdownElement* mWorkingElement{nullptr};
MarkdownBulletList* mWorkingBulletList{nullptr}; MarkdownBulletList* mWorkingBulletList{nullptr};