Enable gcc wall and werror.

test/core/TestBitStream.cpp

@@ -37,6 +37,7 @@ TEST_CASE(TestReadBitStream, "core")
 
     valid = stream.readNextNBits(3, buffer);
     //std::cout << "Slice3 is " << ByteUtils::toString(buffer) << std::endl;
+    REQUIRE(valid);
 }
 
 TEST_CASE(TestWritingBitStream, "core")

test/core/TestByteUtils.cpp

@@ -14,6 +14,7 @@ TEST_CASE(TestReadByteUtils, "core")
 
     auto slice = ByteUtils::getMBitsAtN(byte, 3, 3);
     //std::cout << "Slice is " << ByteUtils::toString(slice) << std::endl;
+    (void) slice;
 
     uint32_t input {12345678};
     auto byte0 = ByteUtils::getByteN(input, 0);
@@ -21,6 +22,11 @@ TEST_CASE(TestReadByteUtils, "core")
     auto byte2 = ByteUtils::getByteN(input, 2);
     auto byte3 = ByteUtils::getByteN(input, 3);
 
+    (void)byte0;
+    (void)byte1;
+    (void)byte2;
+    (void)byte3;
+
     //std::cout << "Byte0 is " << ByteUtils::toString(byte0) << std::endl;
     //std::cout << "Byte1 is " << ByteUtils::toString(byte1) << std::endl;
     //std::cout << "Byte2 is " << ByteUtils::toString(byte2) << std::endl;
@@ -28,10 +34,11 @@ TEST_CASE(TestReadByteUtils, "core")
 
     //std::cout << "Mirroring" << std::endl;
 
-    auto out = ByteUtils::mirror(byte);
+    //auto out = ByteUtils::mirror(byte);
     //std::cout << "Mirror is " << ByteUtils::toString(out) << std::endl;
 
     unsigned hold = byte;
     hold = (hold << 5) + 3;
+    (void)hold;
     //std::cout << "Big val is " << ByteUtils::toString(hold, 16) << std::endl;
 }

test/core/TestDataStructures.cpp

@@ -18,17 +18,20 @@ TEST_CASE(TestCircleBuffer, "core")
     {
         auto item = buffer.getItem(idx);
         //std::cout << "Got item: " << idx << " " << item << std::endl;
+        (void)item;
     }
 
     for (auto item : {4, 5})
     {
         //std::cout << "Add item: " << item << std::endl;
         //buffer.addItem(item);
+        (void)item;
     }
 
     for (std::size_t idx=0; idx<3; idx++)
     {
         auto item = buffer.getItem(idx);
         //std::cout << "Got item: " << idx << " " << item << std::endl;
+        (void)item;
     }
 }

test/core/TestTomlReader.cpp

@@ -12,8 +12,8 @@ TEST_CASE(TestTomlReader, "core")
 
     REQUIRE(themes_table);
 
-    for (const auto& items : themes_table->getKeyValuePairs())
-    {
+    //for (const auto& items : themes_table->getKeyValuePairs())
+    //{
         //std::cout << "Got entry with key: " << items.first << " and val " << items.second << std::endl;
-    }
+    //}
 }