From 7ad237edc1cf8f41f5348b2f8435f2481d074daf Mon Sep 17 00:00:00 2001
From: James Grogan <grogan.ox@gmail.com>
Date: Thu, 17 Nov 2022 08:39:49 +0000
Subject: [PATCH] Sample editor back working.

---
 apps/sample-gui/MediaTool.cpp                 | 21 +++++--------------
 .../audio_editor/AudioEditorView.cpp          |  2 +-
 src/ui_elements/widgets/Button.cpp            | 10 +++++++++
 src/ui_elements/widgets/Label.cpp             | 12 ++++++++++-
 src/ui_elements/widgets/StackWidget.cpp       |  2 ++
 src/ui_elements/widgets/Widget.cpp            | 19 ++++++++++-------
 src/ui_elements/widgets/Widget.h              |  7 ++++++-
 src/visual_elements/AbstractVisualNode.h      | 12 +++++++++++
 src/visual_elements/RectangleNode.cpp         |  9 --------
 src/visual_elements/RectangleNode.h           |  1 -
 10 files changed, 59 insertions(+), 36 deletions(-)

diff --git a/apps/sample-gui/MediaTool.cpp b/apps/sample-gui/MediaTool.cpp
index 5127f62..55a9ff5 100644
--- a/apps/sample-gui/MediaTool.cpp
+++ b/apps/sample-gui/MediaTool.cpp
@@ -29,18 +29,22 @@ void MediaTool::initializeViews()
     auto textEditor = TextEditorView::Create();
     auto path = mMainApplication->getCommandLineArgs()->getLaunchPath();
     path /= "out.txt";
+    textEditor->setName("TextEditor");
     textEditor->GetController()->SetSavePath(path);
     textEditor->GetController()->SetLoadPath(path);
     textEditor->Initialize();
     tabbedPanel->addPanel(std::move(textEditor), "Text Editor");
 
     auto audioEditor = AudioEditorView::Create();
-    tabbedPanel->addPanel(std::move(audioEditor), "Audio Editor");
+    audioEditor->setName("audioEditor");
+    tabbedPanel->addPanel(std::move(audioEditor), "audio Editor");
 
     auto imageEditor = ImageEditorView::Create();
+    imageEditor->setName("imageEditor");
     tabbedPanel->addPanel(std::move(imageEditor), "Image Editor");
 
     auto webClient = WebClientView::Create();
+    webClient->setName("webClient");
     tabbedPanel->addPanel(std::move(webClient), "Web Client");
 
     auto topBar = TopBar::Create();
@@ -51,20 +55,5 @@ void MediaTool::initializeViews()
     horizontal_spacer->addWidgetWithScale(std::move(tabbedPanel), 20);
     horizontal_spacer->addWidgetWithScale(std::move(statusBar), 1);
 
-    /*
-    auto button = Button::Create();
-    button->setLabel("Click!");
-    button->setBounds(100, 200);
-    button->setBackgroundColor(Color(255, 0, 255, 1));
-
-    auto background_widget = Widget::Create();
-    background_widget->setName("BackgroundWidget");
-    background_widget->setBackgroundColor(Color(0, 255, 255, 1));
-
-    auto horizontal_spacer = HorizontalSpacer::Create();
-    horizontal_spacer->addWidgetWithScale(std::move(button), 1);
-    horizontal_spacer->addWidgetWithScale(std::move(background_widget), 1);
-    */
-
     mainWindow->setWidget(std::move(horizontal_spacer));
 }
diff --git a/apps/sample-gui/audio_editor/AudioEditorView.cpp b/apps/sample-gui/audio_editor/AudioEditorView.cpp
index b207d83..f7d6442 100644
--- a/apps/sample-gui/audio_editor/AudioEditorView.cpp
+++ b/apps/sample-gui/audio_editor/AudioEditorView.cpp
@@ -7,7 +7,7 @@
 AudioEditorView::AudioEditorView()
 {
     auto label = Label::Create();
-    label->setLabel("Audio Editor");
+    label->setLabel("audio Editor");
     label->setBackgroundColor(Color(200, 189, 160));
     label->setMargin(1);
     addWidget(std::move(label));
diff --git a/src/ui_elements/widgets/Button.cpp b/src/ui_elements/widgets/Button.cpp
index ac9bcb8..8db6b47 100644
--- a/src/ui_elements/widgets/Button.cpp
+++ b/src/ui_elements/widgets/Button.cpp
@@ -78,6 +78,11 @@ void Button::updateLabel(const PaintEvent* event)
         mRootNode->addChild(mTextNode.get());
     }
 
+    if (mTransformDirty)
+    {
+        mTextNode->setLocation(middle);
+    }
+
     if (mMaterialDirty)
     {
         mTextNode->setFillColor(mBackgroundColor);
@@ -88,4 +93,9 @@ void Button::updateLabel(const PaintEvent* event)
         mTextNode->setContent(mLabel);
         mContentDirty = false;
     }
+
+    if (mVisibilityDirty)
+    {
+        mTextNode->setIsVisible(mVisible);
+    }
 }
diff --git a/src/ui_elements/widgets/Label.cpp b/src/ui_elements/widgets/Label.cpp
index d0b566e..f29b99d 100644
--- a/src/ui_elements/widgets/Label.cpp
+++ b/src/ui_elements/widgets/Label.cpp
@@ -8,7 +8,7 @@ Label::Label()
     : Widget(),
       mLabel()
 {
-
+    mName = "Label";
 }
 
 std::unique_ptr<Label> Label::Create()
@@ -52,9 +52,19 @@ void Label::updateLabel(const PaintEvent* event)
         mTextNode->setFillColor(mBackgroundColor);
     }
 
+    if (mTransformDirty)
+    {
+        mTextNode->setLocation(middle);
+    }
+
     if (mContentDirty)
     {
         mTextNode->setContent(mLabel);
         mContentDirty = false;
     }
+
+    if (mVisibilityDirty)
+    {
+        mTextNode->setIsVisible(mVisible);
+    }
 }
diff --git a/src/ui_elements/widgets/StackWidget.cpp b/src/ui_elements/widgets/StackWidget.cpp
index 2086035..39aaa61 100644
--- a/src/ui_elements/widgets/StackWidget.cpp
+++ b/src/ui_elements/widgets/StackWidget.cpp
@@ -1,5 +1,7 @@
 #include "StackWidget.h"
 
+#include <iostream>
+
 StackWidget::StackWidget()
 {
 
diff --git a/src/ui_elements/widgets/Widget.cpp b/src/ui_elements/widgets/Widget.cpp
index c1fb624..778e49c 100644
--- a/src/ui_elements/widgets/Widget.cpp
+++ b/src/ui_elements/widgets/Widget.cpp
@@ -130,12 +130,13 @@ void Widget::setVisible(bool visible)
     if (mVisible != visible)
     {
         mVisibilityDirty = true;
-    }
-    mVisible = visible;
 
-    for (auto& child : mChildren)
-    {
-        child->setVisible(mVisible);
+        mVisible = visible;
+
+        for (auto& child : mChildren)
+        {
+            child->setVisible(mVisible);
+        }
     }
 }
 
@@ -174,10 +175,15 @@ void Widget::onPaintEvent(const PaintEvent* event)
 
     if (isDirty())
     {
-        mRootNode->setName(mName);
+        mRootNode->setName(mName + "_RootNode");
 
         doPaint(event);
 
+        if (mVisibilityDirty)
+        {
+            mRootNode->setIsVisible(mVisible);
+        }
+
         mTransformDirty = false;
         mMaterialDirty = false;
         mVisibilityDirty = false;
@@ -203,7 +209,6 @@ void Widget::updateChildLocations()
     {
         child->setBounds(mSize.mWidth, mSize.mHeight);
         child->setLocation(mLocation);
-        child->setVisible(mVisible);
     }
 }
 
diff --git a/src/ui_elements/widgets/Widget.h b/src/ui_elements/widgets/Widget.h
index 101cdee..95af36f 100644
--- a/src/ui_elements/widgets/Widget.h
+++ b/src/ui_elements/widgets/Widget.h
@@ -109,6 +109,11 @@ public:
         mName = name;
     }
 
+    const std::string& getName()
+    {
+        return mName;
+    }
+
     bool needsUpdate() const;
 
 protected:
@@ -134,7 +139,7 @@ protected:
     unsigned mBorderThickness{0};
     Color mBackgroundColor;
     Color mBorderColor;
-    bool mVisible{false};
+    bool mVisible{true};
 
     std::unique_ptr<RectangleNode> mBackgroundNode;
 
diff --git a/src/visual_elements/AbstractVisualNode.h b/src/visual_elements/AbstractVisualNode.h
index 9f6e237..2ebdd1f 100644
--- a/src/visual_elements/AbstractVisualNode.h
+++ b/src/visual_elements/AbstractVisualNode.h
@@ -8,6 +8,8 @@
 
 #include <memory>
 
+#include <iostream>
+
 class FontsManager;
 
 class AbstractVisualNode
@@ -54,6 +56,7 @@ public:
 
     void setIsVisible(bool isVisible)
     {
+        //std::cout << "Setting " << mName << " visibility to " << isVisible << std::endl;
         mIsVisible = isVisible;
     }
 
@@ -77,6 +80,15 @@ public:
         return mIsVisible;
     }
 
+    void setLocation(const DiscretePoint& loc)
+    {
+        if (mLocation != loc)
+        {
+            mTransformIsDirty = true;
+            mLocation = loc;
+        }
+    }
+
 protected:
     DiscretePoint mLocation;
     std::unique_ptr<SceneItem> mSceneItem;
diff --git a/src/visual_elements/RectangleNode.cpp b/src/visual_elements/RectangleNode.cpp
index b5e3cf6..1178512 100644
--- a/src/visual_elements/RectangleNode.cpp
+++ b/src/visual_elements/RectangleNode.cpp
@@ -52,15 +52,6 @@ void RectangleNode::setHeight(unsigned height)
     }
 }
 
-void RectangleNode::setLocation(const DiscretePoint& loc)
-{
-    if (mLocation != loc)
-    {
-        mTransformIsDirty = true;
-        mLocation = loc;
-    }
-}
-
 void RectangleNode::update(FontsManager* fontsManager)
 {
     if (!mSceneItem || mGeometryIsDirty)
diff --git a/src/visual_elements/RectangleNode.h b/src/visual_elements/RectangleNode.h
index 16408d3..9c8ae6c 100644
--- a/src/visual_elements/RectangleNode.h
+++ b/src/visual_elements/RectangleNode.h
@@ -17,7 +17,6 @@ public:
 
     void setWidth(unsigned width);
     void setHeight(unsigned height);
-    void setLocation(const DiscretePoint& loc);
 
     void update(FontsManager* fontsManager) override;
 private: